Broken UPDATE synchronization in 3.2.0 master

Tagged: , ,

This topic has 5 replies, 4 voices, and was last updated 6 years, 1 month ago by [email protected].

  • Author
    Posts
  • #5022

    Hello,

    recent commit https://github.com/OpenRock/OpenIDM/commit/0c8e5610a5a9e5b211be2f0c21dd795893bcff01 broke the UPDATE synchronization in ObjectMapping.java:

    – SyncEntry entry = new SyncEntry(op, name, context, dateUtil);
    – op.sourceObjectAccessor = sourceObjectAccessor; // **THIS SHOULD NOT BE REMOVED**
    – entry.sourceObjectId = LazyObjectAccessor.qualifiedId(sourceObjectSet, resourceId);
    + SyncAuditEventLogger syncAuditEvent = new SyncAuditEventLogger(op, name, context);
    + syncAuditEvent.setSourceObjectId(LazyObjectAccessor.qualifiedId(sourceObjectSet, resourceId));

    I would love to contribute as the fix is pretty simple one-liner. But I was not able to find any information whether you are open to community code changes. Also I was not able to create a proper bug report because the login did not work for me.

    #5024
     laurent.bristiel
    Participant

    Hello Pavel,

    thanks for the report and the details.
    The bug is already detected and tracked in Jira.
    I added a link to your message/contribution.

    As for the contribution policy, it is getting worked on at the moment and maybe someone else than me can give more information. (But such a message is already very helpful!).

    For Jira, you should be able to create an account and raise issues. Here again, maybe someone else could help here.

    Laurent

    #5025

    Thank you for a swift response. I am now able to log in to JIRA – it was probably just some slow account synchronization issue (I have just registered).

    If anyone is interested in the fix – https://github.com/orchitech/OpenIDM/commit/9d44c03dbfa14160840c3cc2197fd0883cd22b63.

    We are facing other issues as well so I will try to report them (as proper bugs with Jira access) as I analyze them a bit more.

    #5051
     Mike Jang
    Spectator

    Hi Pavel,

    FYI, the issue Laurent is talking about is OPENIDM-3702.

    As you might have noticed, we are in the process of moving our version control systems to Git. As suggested in this thread, we hope to enable community contributions to Git in the near future.

    Thanks,
    Mike

    #5055
     jason.vincent
    Participant

    Thank you Pavel!

    I have successfully tried out your patch and have merged the change to master.

    Cheers,
    JasonV

    #5060

    Thank you for the information.

Viewing 6 posts - 1 through 6 (of 6 total)

You must be logged in to reply to this topic.

©2021 ForgeRock - we provide an identity and access platform to secure every online relationship for the enterprise market, educational sector and even entire countries. Click to view our privacy policy and terms of use.

Log in with your credentials

Forgot your details?